Unverified Commit 79d11311 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Christian Brauner
Browse files

vfs: document d_dispose_if_unused() 



Add a warning about the danger of using this function without proper
locking preventing eviction.

Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Link: https://patch.msgid.link/20260114145344.468856-7-mszeredi@redhat.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent fa79401a

fs/dcache.c

+10 −0
Original line number Diff line number Diff line
@@ -1104,6 +1104,16 @@ struct dentry *d_find_alias_rcu(struct inode *inode) 
	return de;

}



/**

 * d_dispose_if_unused - move unreferenced dentries to shrink list

 * @dentry: dentry in question

 * @dispose: head of shrink list

 *

 * If dentry has no external references, move it to shrink list.

 *

 * NOTE!!! The caller is responsible for preventing eviction of the dentry by

 * holding dentry->d_inode->i_lock or equivalent.

 */

void d_dispose_if_unused(struct dentry *dentry, struct list_head *dispose)

{

	spin_lock(&dentry->d_lock);