Commit 7a1aba89 authored by Arkadiusz Kubalewski's avatar Arkadiusz Kubalewski Committed by Tony Nguyen
Browse files

ice: dpll: fix initial lock status of dpll 



When dpll device is registered and dpll subsystem performs notify of a
new device, the lock state value provided to dpll subsystem equals 0
which is invalid value for the `enum dpll_lock_status`.
Provide correct value by obtaining it from firmware before registering
the dpll device.

Fixes: d7999f5e ("ice: implement dpll interface to control cgu")
Signed-off-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent c0a2a1b0

drivers/net/ethernet/intel/ice/ice_dpll.c

+1 −2
Original line number Diff line number Diff line
@@ -1756,6 +1756,7 @@ ice_dpll_init_dpll(struct ice_pf *pf, struct ice_dpll *d, bool cgu, 
	}

	d->pf = pf;

	if (cgu) {

		ice_dpll_update_state(pf, d, true);

		ret = dpll_device_register(d->dpll, type, &ice_dpll_ops, d);

		if (ret) {

			dpll_device_put(d->dpll);
@@ -1796,8 +1797,6 @@ static int ice_dpll_init_worker(struct ice_pf *pf) 
	struct ice_dplls *d = &pf->dplls;

	struct kthread_worker *kworker;



	ice_dpll_update_state(pf, &d->eec, true);

	ice_dpll_update_state(pf, &d->pps, true);

	kthread_init_delayed_work(&d->work, ice_dpll_periodic_work);

	kworker = kthread_create_worker(0, "ice-dplls-%s",

					dev_name(ice_pf_to_dev(pf)));