Commit 7a1c2abf authored by Yang Li's avatar Yang Li Committed by Leon Romanovsky
Browse files

RDMA/core: Remove NULL check before dev_{put, hold} 



The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warning:

./drivers/infiniband/core/nldev.c:375:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7047


Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20231024003815.89742-1-yang.lee@linux.alibaba.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent b5570636

drivers/infiniband/core/lag.c

+1 −2
Original line number Diff line number Diff line
@@ -102,7 +102,6 @@ static struct net_device *rdma_get_xmit_slave_udp(struct ib_device *device, 


void rdma_lag_put_ah_roce_slave(struct net_device *xmit_slave)

{

	if (xmit_slave)

	dev_put(xmit_slave);

}

drivers/infiniband/core/nldev.c

+1 −2
Original line number Diff line number Diff line
@@ -371,7 +371,6 @@ static int fill_port_info(struct sk_buff *msg, 
	}



out:

	if (netdev)

	dev_put(netdev);

	return ret;

}

drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c

+4 −8
Original line number Diff line number Diff line
@@ -1021,10 +1021,8 @@ static int pvrdma_pci_probe(struct pci_dev *pdev, 
	pvrdma_free_irq(dev);

	pci_free_irq_vectors(pdev);

err_free_cq_ring:

	if (dev->netdev) {

	dev_put(dev->netdev);

	dev->netdev = NULL;

	}

	pvrdma_page_dir_cleanup(dev, &dev->cq_pdir);

err_free_async_ring:

	pvrdma_page_dir_cleanup(dev, &dev->async_pdir);
@@ -1064,10 +1062,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev) 


	flush_workqueue(event_wq);



	if (dev->netdev) {

	dev_put(dev->netdev);

	dev->netdev = NULL;

	}



	/* Unregister ib device */

	ib_unregister_device(&dev->ib_dev);

drivers/infiniband/ulp/ipoib/ipoib_main.c

+1 −2
Original line number Diff line number Diff line
@@ -2005,7 +2005,6 @@ static void ipoib_ndo_uninit(struct net_device *dev) 
		priv->wq = NULL;

	}



	if (priv->parent)

	dev_put(priv->parent);

}