Commit 7b151e4e authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

net: phy: fixed_phy: remove fixed_phy_register_with_gpiod 



Since its introduction 6 yrs ago this functions has never had a user.
So remove it.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/ccbeef28-65ae-4e28-b1db-816c44338dee@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9cd5ef0b

drivers/net/phy/fixed_phy.c

+7 −25
Original line number Diff line number Diff line
@@ -223,12 +223,12 @@ static struct gpio_desc *fixed_phy_get_gpiod(struct device_node *np) 
}

#endif



static struct phy_device *__fixed_phy_register(unsigned int irq,

struct phy_device *fixed_phy_register(unsigned int irq,

				      struct fixed_phy_status *status,

					       struct device_node *np,

					       struct gpio_desc *gpiod)

				      struct device_node *np)

{

	struct fixed_mdio_bus *fmb = &platform_fmb;

	struct gpio_desc *gpiod;

	struct phy_device *phy;

	int phy_addr;

	int ret;
@@ -237,11 +237,9 @@ static struct phy_device *__fixed_phy_register(unsigned int irq, 
		return ERR_PTR(-EPROBE_DEFER);



	/* Check if we have a GPIO associated with this fixed phy */

	if (!gpiod) {

	gpiod = fixed_phy_get_gpiod(np);

	if (IS_ERR(gpiod))

		return ERR_CAST(gpiod);

	}



	/* Get the next available PHY address, up to PHY_MAX_ADDR */

	phy_addr = ida_alloc_max(&phy_fixed_ida, PHY_MAX_ADDR - 1, GFP_KERNEL);
@@ -306,24 +304,8 @@ static struct phy_device *__fixed_phy_register(unsigned int irq, 


	return phy;

}



struct phy_device *fixed_phy_register(unsigned int irq,

				      struct fixed_phy_status *status,

				      struct device_node *np)

{

	return __fixed_phy_register(irq, status, np, NULL);

}

EXPORT_SYMBOL_GPL(fixed_phy_register);



struct phy_device *

fixed_phy_register_with_gpiod(unsigned int irq,

			      struct fixed_phy_status *status,

			      struct gpio_desc *gpiod)

{

	return __fixed_phy_register(irq, status, NULL, gpiod);

}

EXPORT_SYMBOL_GPL(fixed_phy_register_with_gpiod);



void fixed_phy_unregister(struct phy_device *phy)

{

	phy_device_remove(phy);

include/linux/phy_fixed.h

+0 −14
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ struct fixed_phy_status { 
};



struct device_node;

struct gpio_desc;

struct net_device;



#if IS_ENABLED(CONFIG_FIXED_PHY)
@@ -24,11 +23,6 @@ extern struct phy_device *fixed_phy_register(unsigned int irq, 
					     struct fixed_phy_status *status,

					     struct device_node *np);



extern struct phy_device *

fixed_phy_register_with_gpiod(unsigned int irq,

			      struct fixed_phy_status *status,

			      struct gpio_desc *gpiod);



extern void fixed_phy_unregister(struct phy_device *phydev);

extern int fixed_phy_set_link_update(struct phy_device *phydev,

			int (*link_update)(struct net_device *,
@@ -46,14 +40,6 @@ static inline struct phy_device *fixed_phy_register(unsigned int irq, 
	return ERR_PTR(-ENODEV);

}



static inline struct phy_device *

fixed_phy_register_with_gpiod(unsigned int irq,

			      struct fixed_phy_status *status,

			      struct gpio_desc *gpiod)

{

	return ERR_PTR(-ENODEV);

}



static inline void fixed_phy_unregister(struct phy_device *phydev)

{

}