Commit 7bca2b2d authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Jakub Kicinski
Browse files

net: renesas: rswitch: Convert to for_each_available_child_of_node() 



Simplify rswitch_get_port_node() by using the
for_each_available_child_of_node() helper instead of manually ignoring
unavailable child nodes, and leaking a reference.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/54f544d573a64b96e01fd00d3481b10806f4d110.1738771798.git.geert+renesas@glider.be


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 02c97223

drivers/net/ethernet/renesas/rswitch.c

+2 −5
Original line number Diff line number Diff line
@@ -1287,18 +1287,15 @@ static struct device_node *rswitch_get_port_node(struct rswitch_device *rdev) 
	if (!ports)

		return NULL;



	for_each_child_of_node(ports, port) {

	for_each_available_child_of_node(ports, port) {

		err = of_property_read_u32(port, "reg", &index);

		if (err < 0) {

			port = NULL;

			goto out;

		}

		if (index == rdev->etha->index) {

			if (!of_device_is_available(port))

				port = NULL;

		if (index == rdev->etha->index)

			break;

	}

	}



out:

	of_node_put(ports);