Commit 7c1cf555 authored by Yang Li's avatar Yang Li Committed by Bartosz Golaszewski
Browse files

gpio: idt3243x: Fix an ignored error return from platform_get_irq() 



The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'parent_irq', so making 'parent_irq' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression
compared with zero: parent_irq < 0

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Fixes: 30fee1d7 ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 30fee1d7

drivers/gpio/gpio-idt3243x.c

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev) 
	struct device *dev = &pdev->dev;

	struct gpio_irq_chip *girq;

	struct idt_gpio_ctrl *ctrl;

	unsigned int parent_irq;

	int parent_irq;

	int ngpios;

	int ret;