Commit 7c977019 authored by Stefan Eichenberger's avatar Stefan Eichenberger Committed by Lee Jones
Browse files

leds: lp55xx: Use gpiod_set_value_cansleep() 



Use gpiod_set_value_cansleep in the init_device function. Without this
change, the driver may print a warning if the LP55xx enable pin is
connected to a GPIO chip which can sleep (e.g. a GPIO expander):

WARNING: CPU: 0 PID: 2719 at drivers/gpio/gpiolib.c:3051 gpiod_set_value+0x64/0xbc

Signed-off-by: default avatarStefan Eichenberger <eichest@gmail.com>
Link: https://lore.kernel.org/r/20230918143238.75600-1-eichest@gmail.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent e3c9d952

drivers/leds/leds-lp55xx-common.c

+2 −2
Original line number Diff line number Diff line
@@ -442,9 +442,9 @@ int lp55xx_init_device(struct lp55xx_chip *chip) 
		gpiod_direction_output(pdata->enable_gpiod, 0);



		gpiod_set_consumer_name(pdata->enable_gpiod, "LP55xx enable");

		gpiod_set_value(pdata->enable_gpiod, 0);

		gpiod_set_value_cansleep(pdata->enable_gpiod, 0);

		usleep_range(1000, 2000); /* Keep enable down at least 1ms */

		gpiod_set_value(pdata->enable_gpiod, 1);

		gpiod_set_value_cansleep(pdata->enable_gpiod, 1);

		usleep_range(1000, 2000); /* 500us abs min. */

	}