Commit 7cfeb903 authored by Steven Rostedt (Google)'s avatar Steven Rostedt (Google)
Browse files

tracing: Update function tracing output for previous boot buffer 

For a persistent ring buffer that is saved across boots, if function
tracing was performed in the previous boot, it only saves the address of
the functions and uses "%pS" to print their names. But the current boot,
those functions may be in different locations. The persistent meta-data
saves the text delta between the two boots and can be used to find the
address of the saved function of where it is located in the current boot.

Link: https://lkml.kernel.org/r/20240612232026.988226055@goodmis.org



Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Vincent Donnefort <vdonnefort@google.com>
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vineeth Pillai <vineeth@bitbyteword.org>
Cc: Youssef Esmat <youssefesmat@google.com>
Cc: Beau Belgrave <beaub@linux.microsoft.com>
Cc: Alexander Graf <graf@amazon.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Ross Zwisler <zwisler@google.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 07714b4b

kernel/trace/trace_output.c

+6 −3
Original line number Diff line number Diff line
@@ -990,8 +990,11 @@ enum print_line_t trace_nop_print(struct trace_iterator *iter, int flags, 
}



static void print_fn_trace(struct trace_seq *s, unsigned long ip,

			   unsigned long parent_ip, int flags)

			   unsigned long parent_ip, long delta, int flags)

{

	ip += delta;

	parent_ip += delta;



	seq_print_ip_sym(s, ip, flags);



	if ((flags & TRACE_ITER_PRINT_PARENT) && parent_ip) {
@@ -1009,7 +1012,7 @@ static enum print_line_t trace_fn_trace(struct trace_iterator *iter, int flags, 


	trace_assign_type(field, iter->ent);



	print_fn_trace(s, field->ip, field->parent_ip, flags);

	print_fn_trace(s, field->ip, field->parent_ip, iter->tr->text_delta, flags);

	trace_seq_putc(s, '\n');



	return trace_handle_return(s);
@@ -1674,7 +1677,7 @@ trace_func_repeats_print(struct trace_iterator *iter, int flags, 


	trace_assign_type(field, iter->ent);



	print_fn_trace(s, field->ip, field->parent_ip, flags);

	print_fn_trace(s, field->ip, field->parent_ip, iter->tr->text_delta, flags);

	trace_seq_printf(s, " (repeats: %u, last_ts:", field->count);

	trace_print_time(s, iter,

			 iter->ts - FUNC_REPEATS_GET_DELTA_TS(field));