Unverified Commit 7db53c21 authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown
Browse files

ASoC: core: Remove invalid snd_soc_component_set_jack call 



If snd_soc_component_set_jack() is called after
snd_soc_component_remove() it may operate on memory which is freed in
->remove handler.

Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20211015161257.27052-2-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b6a4e209

sound/soc/soc-core.c

+0 −3
Original line number Diff line number Diff line
@@ -1342,9 +1342,6 @@ static void soc_remove_component(struct snd_soc_component *component, 
	if (probed)

		snd_soc_component_remove(component);



	/* For framework level robustness */

	snd_soc_component_set_jack(component, NULL, NULL);



	list_del_init(&component->card_list);

	snd_soc_dapm_free(snd_soc_component_get_dapm(component));

	soc_cleanup_component_debugfs(component);