Commit 7dc10eff authored by Lucas De Marchi's avatar Lucas De Marchi
Browse files

drm/xe/rtp: Fix out-of-bounds array access 



Increment the counter before checking for number of rules, otherwise
when there's no XE_RTP_MATCH_OR an out-of-bounds access is done, as
reported by kasan:

	BUG: KASAN: global-out-of-bounds in rule_matches+0xb6d/0x11c0 [xe]
	Read of size 1 at addr ffffffffa0a50b70 by task systemd-udevd/243

Fixes: dc72c52a ("drm/xe/rtp: Allow to OR rules")
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240628161726.836734-1-lucas.demarchi@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 41122080

drivers/gpu/drm/xe/xe_rtp.c

+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ static bool rule_matches(const struct xe_device *xe, 
			 * Advance rules until we find XE_RTP_MATCH_OR to check

			 * if there's another set of conditions to check

			 */

			while (i < n_rules && rules[++i].match_type != XE_RTP_MATCH_OR)

			while (++i < n_rules && rules[i].match_type != XE_RTP_MATCH_OR)

				;



			if (i >= n_rules)