Commit 7dc918da authored by Esther Shimanovich's avatar Esther Shimanovich Committed by Rafael J. Wysocki
Browse files

ACPI: video: force native for Apple MacbookPro9,2 



It used to be that the MacbookPro9,2 used its native intel backlight
device until the following commit was introduced:

commit b1d36e73 ("drm/i915: Don't register backlight when another
backlight should be used (v2)")

This commit forced this model to use its firmware acpi_video backlight
device instead.

That worked fine until an additional commit was added:

commit 92714006 ("drm/i915/backlight: Do not bump min brightness
to max on enable")

That commit uncovered a bug in the MacbookPro 9,2's acpi_video
backlight firmware; the backlight does not come back up after resume.

Add DMI quirk to select the working native intel interface instead
so that the backlight successfully comes back up after resume.

Fixes: 92714006 ("drm/i915/backlight: Do not bump min brightness to max on enable")
Signed-off-by: default avatarEsther Shimanovich <eshimanovich@chromium.org>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://patch.msgid.link/20240806-acpi-video-quirk-v1-1-369d8f7abc59@chromium.org


[ rjw: Subject and changelog edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5be63fc1

drivers/acpi/video_detect.c

+8 −0
Original line number Diff line number Diff line
@@ -549,6 +549,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { 
		DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"),

		},

	},

	{

	 .callback = video_detect_force_native,

	 /* Apple MacBook Pro 9,2 */

	 .matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),

		DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro9,2"),

		},

	},

	{

	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */

	 .callback = video_detect_force_native,