Commit 7dd0d6d1 authored by Niklas Söderlund's avatar Niklas Söderlund Committed by Hans Verkuil
Browse files

media: adv748x: Remove g_pixelaspect implementation 



There are no consumer left of g_pixelaspect in the tree, remove the
implementation from the adv748x driver in preparation of removing it
from struct v4l2_subdev_video_ops all together.

Signed-off-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Link: https://lore.kernel.org/r/20250705083741.77517-3-niklas.soderlund+renesas@ragnatech.se


Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 78c633ae

drivers/media/i2c/adv748x/adv748x-afe.c

+0 −17
Original line number Diff line number Diff line
@@ -161,22 +161,6 @@ int adv748x_afe_s_input(struct adv748x_afe *afe, unsigned int input) 
	return sdp_write(state, ADV748X_SDP_INSEL, input);

}



static int adv748x_afe_g_pixelaspect(struct v4l2_subdev *sd,

				     struct v4l2_fract *aspect)

{

	struct adv748x_afe *afe = adv748x_sd_to_afe(sd);



	if (afe->curr_norm & V4L2_STD_525_60) {

		aspect->numerator = 11;

		aspect->denominator = 10;

	} else {

		aspect->numerator = 54;

		aspect->denominator = 59;

	}



	return 0;

}



/* -----------------------------------------------------------------------------

 * v4l2_subdev_video_ops

 */
@@ -307,7 +291,6 @@ static const struct v4l2_subdev_video_ops adv748x_afe_video_ops = { 
	.g_tvnorms = adv748x_afe_g_tvnorms,

	.g_input_status = adv748x_afe_g_input_status,

	.s_stream = adv748x_afe_s_stream,

	.g_pixelaspect = adv748x_afe_g_pixelaspect,

};



/* -----------------------------------------------------------------------------

drivers/media/i2c/adv748x/adv748x-hdmi.c

+0 −10
Original line number Diff line number Diff line
@@ -382,19 +382,9 @@ static int adv748x_hdmi_s_stream(struct v4l2_subdev *sd, int enable) 
	return ret;

}



static int adv748x_hdmi_g_pixelaspect(struct v4l2_subdev *sd,

				      struct v4l2_fract *aspect)

{

	aspect->numerator = 1;

	aspect->denominator = 1;



	return 0;

}



static const struct v4l2_subdev_video_ops adv748x_video_ops_hdmi = {

	.g_input_status = adv748x_hdmi_g_input_status,

	.s_stream = adv748x_hdmi_s_stream,

	.g_pixelaspect = adv748x_hdmi_g_pixelaspect,

};



/* -----------------------------------------------------------------------------