Commit 7ec1bd3d authored by Potin Lai's avatar Potin Lai Committed by Andrew Jeffery
Browse files

soc: aspeed: socinfo: Mask table entries for accurate SoC ID matching 



The siliconid_to_name() function currently masks the input silicon ID
with 0xff00ffff, but compares it against unmasked table entries. This
causes matching to fail if the table entries contain non-zero values in
the bits covered by the mask (bits 16-23).

Update the logic to apply the 0xff00ffff mask to the table entries
during comparison. This ensures that only the relevant model and
revision bits are considered, providing a consistent match across
different manufacturing batches.

[arj: Add Fixes: tag, fix 'soninfo' typo, clarify function reference]

Fixes: e0218dca ("soc: aspeed: Add soc info driver")
Signed-off-by: default avatarPotin Lai <potin.lai.pt@gmail.com>
Link: https://patch.msgid.link/20260122-soc_aspeed_name_fix-v1-1-33a847f2581c@gmail.com


Signed-off-by: default avatarAndrew Jeffery <andrew@codeconstruct.com.au>
parent 6de23f81

drivers/soc/aspeed/aspeed-socinfo.c

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ static const char *siliconid_to_name(u32 siliconid) 
	unsigned int i;



	for (i = 0 ; i < ARRAY_SIZE(rev_table) ; ++i) {

		if (rev_table[i].id == id)

		if ((rev_table[i].id & 0xff00ffff) == id)

			return rev_table[i].name;

	}