Commit 7fddac12 authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

driver core: Fix device_link_flag_is_sync_state_only() 



device_link_flag_is_sync_state_only() correctly returns true on the flags
of an existing device link that only implements sync_state() functionality.
However, it incorrectly and confusingly returns false if it's called with
DL_FLAG_SYNC_STATE_ONLY.

This bug doesn't manifest in any of the existing calls to this function,
but fix this confusing behavior to avoid future bugs.

Fixes: 67cad5c6 ("driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links")
Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Tested-by: default avatarXu Yang <xu.yang_2@nxp.com>
Link: https://lore.kernel.org/r/20240202095636.868578-2-saravanak@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 98323e9d

drivers/base/core.c

+4 −2
Original line number Diff line number Diff line
@@ -284,10 +284,12 @@ static bool device_is_ancestor(struct device *dev, struct device *target) 
	return false;

}



#define DL_MARKER_FLAGS		(DL_FLAG_INFERRED | \

				 DL_FLAG_CYCLE | \

				 DL_FLAG_MANAGED)

static inline bool device_link_flag_is_sync_state_only(u32 flags)

{

	return (flags & ~(DL_FLAG_INFERRED | DL_FLAG_CYCLE)) ==

		(DL_FLAG_SYNC_STATE_ONLY | DL_FLAG_MANAGED);

	return (flags & ~DL_MARKER_FLAGS) == DL_FLAG_SYNC_STATE_ONLY;

}



/**