Unverified Commit 80339b38 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: SDCA: Fix NULL vs IS_ERR() bug in sdca_dev_register_functions() 



The sdca_dev_register() function never returns NULL, it returns error
pointers on error.  Fix the error checking to match.

Fixes: 4496d1c6 ("ASoC: SDCA: add function devices")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/aSW1UOgMCiQIaZG8@stanley.mountain


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a13744f6

sound/soc/sdca/sdca_function_device.c

+2 −2
Original line number Diff line number Diff line
@@ -96,8 +96,8 @@ int sdca_dev_register_functions(struct sdw_slave *slave) 


		func_dev = sdca_dev_register(&slave->dev,

					     &sdca_data->function[i]);

		if (!func_dev)

			return -ENODEV;

		if (IS_ERR(func_dev))

			return PTR_ERR(func_dev);



		sdca_data->function[i].func_dev = func_dev;

	}