Commit 80ad07f7 authored by Md Haris Iqbal's avatar Md Haris Iqbal Committed by Jason Gunthorpe
Browse files

RDMA/rtrs: Remove len parameter from helper print functions of sysfs 

Since we have changed all sysfs show functions to use sysfs_emit, we do
not require the len (PAGE_SIZE) in our helper print functions. So remove
it from the function parameter.

Link: https://lore.kernel.org/r/20210922125333.351454-3-haris.iqbal@ionos.com


Signed-off-by: default avatarMd Haris Iqbal <haris.iqbal@ionos.com>
Signed-off-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 2f232912

drivers/infiniband/ulp/rtrs/rtrs-clt-stats.c

+4 −8
Original line number Diff line number Diff line
@@ -37,8 +37,7 @@ void rtrs_clt_inc_failover_cnt(struct rtrs_clt_stats *stats) 
	s->rdma.failover_cnt++;

}



int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats,

					 char *buf, size_t len)

int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, char *buf)

{

	struct rtrs_clt_stats_pcpu *s;
@@ -66,15 +65,13 @@ int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, 
	return used;

}



int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf,

				      size_t len)

int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf)

{

	return sysfs_emit(buf, "%d %d\n", stats->reconnects.successful_cnt,

			  stats->reconnects.fail_cnt);

}



ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats,

				    char *page, size_t len)

ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats, char *page)

{

	struct rtrs_clt_stats_rdma sum;

	struct rtrs_clt_stats_rdma *r;
@@ -98,8 +95,7 @@ ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats, 
			 atomic_read(&stats->inflight), sum.failover_cnt);

}



ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *s,

				 char *page, size_t len)

ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *s, char *page)

{

	return sysfs_emit(page, "echo 1 to reset all statistics\n");

}

drivers/infiniband/ulp/rtrs/rtrs-clt.h

+5 −7
Original line number Diff line number Diff line
@@ -224,19 +224,17 @@ void rtrs_clt_update_all_stats(struct rtrs_clt_io_req *req, int dir); 
int rtrs_clt_reset_rdma_lat_distr_stats(struct rtrs_clt_stats *stats,

					 bool enable);

ssize_t rtrs_clt_stats_rdma_lat_distr_to_str(struct rtrs_clt_stats *stats,

					      char *page, size_t len);

					      char *page);

int rtrs_clt_reset_cpu_migr_stats(struct rtrs_clt_stats *stats, bool enable);

int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, char *buf,

					 size_t len);

int rtrs_clt_stats_migration_cnt_to_str(struct rtrs_clt_stats *stats, char *buf);

int rtrs_clt_reset_reconnects_stat(struct rtrs_clt_stats *stats, bool enable);

int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf,

				     size_t len);

int rtrs_clt_stats_reconnects_to_str(struct rtrs_clt_stats *stats, char *buf);

int rtrs_clt_reset_rdma_stats(struct rtrs_clt_stats *stats, bool enable);

ssize_t rtrs_clt_stats_rdma_to_str(struct rtrs_clt_stats *stats,

				    char *page, size_t len);

				    char *page);

int rtrs_clt_reset_all_stats(struct rtrs_clt_stats *stats, bool enable);

ssize_t rtrs_clt_reset_all_help(struct rtrs_clt_stats *stats,

				 char *page, size_t len);

				 char *page);



/* rtrs-clt-sysfs.c */

drivers/infiniband/ulp/rtrs/rtrs-pri.h

+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ static ssize_t get_value##_show(struct kobject *kobj, \ 
{									\

	type *stats = container_of(kobj, type, kobj_stats);		\

									\

	return print(stats, page, PAGE_SIZE);			\

	return print(stats, page);			\

}



#define STAT_ATTR(type, stat, print, reset)				\

drivers/infiniband/ulp/rtrs/rtrs-srv-stats.c

+1 −2
Original line number Diff line number Diff line
@@ -23,8 +23,7 @@ int rtrs_srv_reset_rdma_stats(struct rtrs_srv_stats *stats, bool enable) 
	return -EINVAL;

}



ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats,

				    char *page, size_t len)

ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats, char *page)

{

	struct rtrs_srv_stats_rdma_stats *r = &stats->rdma_stats;

drivers/infiniband/ulp/rtrs/rtrs-srv.h

+1 −2
Original line number Diff line number Diff line
@@ -136,8 +136,7 @@ static inline void rtrs_srv_update_rdma_stats(struct rtrs_srv_stats *s, 


/* functions which are implemented in rtrs-srv-stats.c */

int rtrs_srv_reset_rdma_stats(struct rtrs_srv_stats *stats, bool enable);

ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats,

				    char *page, size_t len);

ssize_t rtrs_srv_stats_rdma_to_str(struct rtrs_srv_stats *stats, char *page);

int rtrs_srv_reset_all_stats(struct rtrs_srv_stats *stats, bool enable);

ssize_t rtrs_srv_reset_all_help(struct rtrs_srv_stats *stats,

				 char *page, size_t len);