Commit 80b61046 authored by David Laight's avatar David Laight Committed by Herbert Xu
Browse files

crypto: lib/mpi - use min() instead of min_t() 



min_t(unsigned int, a, b) casts an 'unsigned long' to 'unsigned int'.
Use min(a, b) instead as it promotes any 'unsigned int' to 'unsigned long'
and so cannot discard significant bits.

In this case the 'unsigned long' value is small enough that the result
is ok.

Detected by an extra check added to min_t().

Signed-off-by: default avatarDavid Laight <david.laight.linux@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 14ca8ce1

lib/crypto/mpi/mpicoder.c

+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int nbytes) 


	while (sg_miter_next(&miter)) {

		buff = miter.addr;

		len = min_t(unsigned, miter.length, nbytes);

		len = min(miter.length, nbytes);

		nbytes -= len;



		for (x = 0; x < len; x++) {