Unverified Commit 812062e7 authored by Brajesh Gupta's avatar Brajesh Gupta Committed by Matt Coster
Browse files

drm/imagination: Wait for FW trace update command completion 



Possibility of no FW trace available after update in the fw_trace_mask due
to asynchronous mode of command consumption in the FW.

To ensure FW trace is available after update, wait for FW trace log update
command completion from the FW.

Fixes: cc1aeedb ("drm/imagination: Implement firmware infrastructure and META FW support")
Signed-off-by: default avatarBrajesh Gupta <brajesh.gupta@imgtec.com>
Reviewed-by: default avatarMatt Coster <matt.coster@imgtec.com>
Link: https://patch.msgid.link/20260108040936.129769-1-brajesh.gupta@imgtec.com


Signed-off-by: default avatarMatt Coster <matt.coster@imgtec.com>
parent b91a565e

drivers/gpu/drm/imagination/pvr_fw_trace.c

+7 −1
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask) 
	struct rogue_fwif_kccb_cmd cmd;

	int idx;

	int err;

	int slot;



	if (group_mask)

		fw_trace->tracebuf_ctrl->log_type = ROGUE_FWIF_LOG_TYPE_TRACE | group_mask;
@@ -154,8 +155,13 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask) 
	cmd.cmd_type = ROGUE_FWIF_KCCB_CMD_LOGTYPE_UPDATE;

	cmd.kccb_flags = 0;



	err = pvr_kccb_send_cmd(pvr_dev, &cmd, NULL);

	err = pvr_kccb_send_cmd(pvr_dev, &cmd, &slot);

	if (err)

		goto err_drm_dev_exit;



	err = pvr_kccb_wait_for_completion(pvr_dev, slot, HZ, NULL);



err_drm_dev_exit:

	drm_dev_exit(idx);



err_up_read: