Commit 8151320c authored by Chen Yu's avatar Chen Yu Committed by Rafael J. Wysocki
Browse files

ACPI: pfr_update: Fix the driver update version check 



The security-version-number check should be used rather
than the runtime version check for driver updates.

Otherwise, the firmware update would fail when the update binary had
a lower runtime version number than the current one.

Fixes: 0db89fa2 ("ACPI: Introduce Platform Firmware Runtime Update device driver")
Cc: 5.17+ <stable@vger.kernel.org> # 5.17+
Reported-by: default avatar"Govindarajulu, Hariganesh" <hariganesh.govindarajulu@intel.com>
Signed-off-by: default avatarChen Yu <yu.c.chen@intel.com>
Link: https://patch.msgid.link/20250722143233.3970607-1-yu.c.chen@intel.com


[ rjw: Changelog edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent c17b750b

drivers/acpi/pfr_update.c

+1 −1
Original line number Diff line number Diff line
@@ -329,7 +329,7 @@ static bool applicable_image(const void *data, struct pfru_update_cap_info *cap, 
	if (type == PFRU_CODE_INJECT_TYPE)

		return payload_hdr->rt_ver >= cap->code_rt_version;



	return payload_hdr->rt_ver >= cap->drv_rt_version;

	return payload_hdr->svn_ver >= cap->drv_svn;

}



static void print_update_debug_info(struct pfru_updated_result *result,

include/uapi/linux/pfrut.h

+1 −0
Original line number Diff line number Diff line
@@ -89,6 +89,7 @@ struct pfru_payload_hdr { 
	__u32 hw_ver;

	__u32 rt_ver;

	__u8 platform_id[16];

	__u32 svn_ver;

};



enum pfru_dsm_status {