Commit 81a206d7 authored by Yang Yingliang's avatar Yang Yingliang Committed by Abel Vesa
Browse files

clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains() 



If device_link_add() fails, it returns NULL pointer not ERR_PTR(),
replace IS_ERR() with NULL pointer check, and return -EINVAL.

Fixes: d3a0946d ("clk: imx: imx8: add audio clock mux driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Reviewed-by: default avatarAbel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241026112452.1523-1-yangyingliang@huaweicloud.com


Signed-off-by: default avatarAbel Vesa <abel.vesa@linaro.org>
parent 92888f39

drivers/clk/imx/clk-imx8-acm.c

+2 −2
Original line number Diff line number Diff line
@@ -294,9 +294,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev, 
							 DL_FLAG_STATELESS |

							 DL_FLAG_PM_RUNTIME |

							 DL_FLAG_RPM_ACTIVE);

		if (IS_ERR(dev_pm->pd_dev_link[i])) {

		if (!dev_pm->pd_dev_link[i]) {

			dev_pm_domain_detach(dev_pm->pd_dev[i], false);

			ret = PTR_ERR(dev_pm->pd_dev_link[i]);

			ret = -EINVAL;

			goto detach_pm;

		}

	}