Commit 81a9a93b authored by Dmitry Baryshkov's avatar Dmitry Baryshkov
Browse files

drm/vc4: hdmi: use eld_mutex to protect access to connector->eld 



Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.

Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241206-drm-connector-eld-mutex-v2-10-c9bce1ee8bea@linaro.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent e99c0b51

drivers/gpu/drm/vc4/vc4_hdmi.c

+2 −2
Original line number Diff line number Diff line
@@ -2220,9 +2220,9 @@ static int vc4_hdmi_audio_get_eld(struct device *dev, void *data, 
	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);

	struct drm_connector *connector = &vc4_hdmi->connector;



	mutex_lock(&vc4_hdmi->mutex);

	mutex_lock(&connector->eld_mutex);

	memcpy(buf, connector->eld, min(sizeof(connector->eld), len));

	mutex_unlock(&vc4_hdmi->mutex);

	mutex_unlock(&connector->eld_mutex);



	return 0;

}