Commit 81c05e47 authored Sep 11, 2024 by Dominik Karol Piątkowski Committed by Greg Kroah-Hartman Sep 13, 2024

staging: vt6655: mac.h: Fix possible precedence issue in macros

It is safer to put macro arguments in parentheses. This way, accidental
operator precedence issues can be avoided.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240911180149.14474-1-dominik.karol.piatkowski@protonmail.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e6e63993

drivers/staging/vt6655/mac.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -537,9 +537,9 @@

		/--------------------- Export Macros ------------------------------/

		#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, iobase + MAC_REG_PAGE1SEL)
		#define VT6655_MAC_SELECT_PAGE0(iobase) iowrite8(0, (iobase) + MAC_REG_PAGE1SEL)

		#define VT6655_MAC_SELECT_PAGE1(iobase) iowrite8(1, iobase + MAC_REG_PAGE1SEL)
		#define VT6655_MAC_SELECT_PAGE1(iobase) iowrite8(1, (iobase) + MAC_REG_PAGE1SEL)

		#define MAKEWORD(lb, hb) \
		((unsigned short)(((unsigned char)(lb)) \| (((unsigned short)((unsigned char)(hb))) << 8)))