Commit 822bc8ea authored by Muhammad Usama Anjum's avatar Muhammad Usama Anjum Committed by Steve French
Browse files

cifsd: use kfree to free memory allocated by kmalloc or kzalloc 



kfree should be used to free memory allocated by kmalloc or kzalloc to
avoid any overhead and for maintaining consistency.

Signed-off-by: default avatarMuhammad Usama Anjum <musamaanjum@gmail.com>
Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent c250e8f5

fs/cifsd/buffer_pool.c

+2 −2
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ static int register_wm_size_class(size_t sz) 
	list_for_each_entry(l, &wm_lists, list) {

		if (l->sz == sz) {

			write_unlock(&wm_lists_lock);

			kvfree(nl);

			kfree(nl);

			return 0;

		}

	}
@@ -181,7 +181,7 @@ static void wm_list_free(struct wm_list *l) 
		list_del(&wm->list);

		kvfree(wm);

	}

	kvfree(l);

	kfree(l);

}



static void wm_lists_destroy(void)

fs/cifsd/mgmt/share_config.c

+1 −1
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ static int parse_veto_list(struct ksmbd_share_config *share, 


		p->pattern = kstrdup(veto_list, GFP_KERNEL);

		if (!p->pattern) {

			ksmbd_free(p);

			kfree(p);

			return -ENOMEM;

		}

fs/cifsd/mgmt/user_config.c

+4 −4
Original line number Diff line number Diff line
@@ -46,8 +46,8 @@ struct ksmbd_user *ksmbd_alloc_user(struct ksmbd_login_response *resp) 


	if (!user->name || !user->passkey) {

		kfree(user->name);

		ksmbd_free(user->passkey);

		ksmbd_free(user);

		kfree(user->passkey);

		kfree(user);

		user = NULL;

	}

	return user;
@@ -57,8 +57,8 @@ void ksmbd_free_user(struct ksmbd_user *user) 
{

	ksmbd_ipc_logout_request(user->name);

	kfree(user->name);

	ksmbd_free(user->passkey);

	ksmbd_free(user);

	kfree(user->passkey);

	kfree(user);

}



int ksmbd_anonymous_user(struct ksmbd_user *user)

fs/cifsd/mgmt/user_session.c

+3 −3
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ static void __session_rpc_close(struct ksmbd_session *sess, 


	ksmbd_free(resp);

	ksmbd_rpc_id_free(entry->id);

	ksmbd_free(entry);

	kfree(entry);

}



static void ksmbd_session_rpc_clear_list(struct ksmbd_session *sess)
@@ -121,7 +121,7 @@ int ksmbd_session_rpc_open(struct ksmbd_session *sess, char *rpc_name) 
	return entry->id;

error:

	list_del(&entry->list);

	ksmbd_free(entry);

	kfree(entry);

	return -EINVAL;

}
@@ -176,7 +176,7 @@ void ksmbd_session_destroy(struct ksmbd_session *sess) 
	ksmbd_release_id(session_ida, sess->id);



	ksmbd_ida_free(sess->tree_conn_ida);

	ksmbd_free(sess);

	kfree(sess);

}



static struct ksmbd_session *__session_lookup(unsigned long long id)

fs/cifsd/smb2pdu.c

+2 −2
Original line number Diff line number Diff line
@@ -1611,7 +1611,7 @@ int smb2_sess_setup(struct ksmbd_work *work) 


			ksmbd_conn_set_good(work);

			sess->state = SMB2_SESSION_VALID;

			ksmbd_free(sess->Preauth_HashValue);

			kfree(sess->Preauth_HashValue);

			sess->Preauth_HashValue = NULL;

		} else if (conn->preferred_auth_mech == KSMBD_AUTH_NTLMSSP) {

			rc = generate_preauth_hash(work);
@@ -1637,7 +1637,7 @@ int smb2_sess_setup(struct ksmbd_work *work) 


				ksmbd_conn_set_good(work);

				sess->state = SMB2_SESSION_VALID;

				ksmbd_free(sess->Preauth_HashValue);

				kfree(sess->Preauth_HashValue);

				sess->Preauth_HashValue = NULL;

			}

		} else {