Unverified Commit 8241fffa authored Sep 28, 2021 by Konstantin Komarov

fs/ntfs3: Forbid FALLOC_FL_PUNCH_HOLE for normal files



FALLOC_FL_PUNCH_HOLE isn't allowed with normal files.
Filesystem must remember info about hole, but for normal file
we can only zero it and forget.

Fixes: 4342306f ("fs/ntfs3: Add file operations and implementation")
Now xfstests generic/016 generic/021 generic/022 pass.

Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

parent cff32466

fs/ntfs3/file.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -587,8 +587,11 @@ static long ntfs_fallocate(struct file *file, int mode, loff_t vbo, loff_t len)
		truncate_pagecache(inode, vbo_down);

		if (!is_sparsed(ni) && !is_compressed(ni)) {
		/* Normal file. */
		err = ntfs_zero_range(inode, vbo, end);
		/*
		* Normal file, can't make hole.
		* TODO: Try to find way to save info about hole.
		*/
		err = -EOPNOTSUPP;
		goto out;
		}