Commit 83617f5a authored by Yuri Nudelman's avatar Yuri Nudelman Committed by Greg Kroah-Hartman
Browse files

habanalabs: order memory manager messages 



Changing format of memory manager messages to make it more readable. In
addition, reducing the priority of a warning on missing handle during
put. This scenario is not an indication of a problem and may happen in
a legal flow, when handle is put from multiple flows. For example, in
timeout and completion.

Signed-off-by: default avatarYuri Nudelman <ynudelman@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 804d514d

drivers/misc/habanalabs/common/memory_mgr.c

+4 −4
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ struct hl_mmap_mem_buf *hl_mmap_mem_buf_get(struct hl_mem_mgr *mmg, u64 handle) 
	if (!buf) {

		spin_unlock(&mmg->lock);

		dev_warn(mmg->dev,

			 "Buff get failed, no match to handle %llu\n", handle);

			 "Buff get failed, no match to handle %#llx\n", handle);

		return NULL;

	}

	kref_get(&buf->refcount);
@@ -119,8 +119,8 @@ int hl_mmap_mem_buf_put_handle(struct hl_mem_mgr *mmg, u64 handle) 
	buf = idr_find(&mmg->handles, lower_32_bits(handle >> PAGE_SHIFT));

	if (!buf) {

		spin_unlock(&mmg->lock);

		dev_warn(mmg->dev,

			 "Buff put failed, no match to handle %llu\n", handle);

		dev_dbg(mmg->dev,

			 "Buff put failed, no match to handle %#llx\n", handle);

		return -EINVAL;

	}
@@ -246,7 +246,7 @@ int hl_mem_mgr_mmap(struct hl_mem_mgr *mmg, struct vm_area_struct *vma, 
	buf = hl_mmap_mem_buf_get(mmg, handle);

	if (!buf) {

		dev_err(mmg->dev,

			"Memory mmap failed, no match to handle %llu\n", handle);

			"Memory mmap failed, no match to handle %#llx\n", handle);

		return -EINVAL;

	}