Commit 8402a158 authored by Abhinav Jain's avatar Abhinav Jain Committed by Jakub Kicinski
Browse files

selftests: net: Use XFAIL for operations not supported by the driver 



Check if veth pair was created and if yes, xfail on setting IP address
logging an informational message.
Use XFAIL instead of SKIP for unsupported ethtool APIs.

Signed-off-by: default avatarAbhinav Jain <jain.abhinav177@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240821171903.118324-4-jain.abhinav177@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6ce7bdbc

tools/testing/selftests/net/netdevice.sh

+7 −3
Original line number Diff line number Diff line
@@ -67,8 +67,12 @@ kci_net_setup() 
		return $ksft_skip

	fi



	if [ "$veth_created" ]; then

		echo "XFAIL: $netdev: set IP address unsupported for veth*"

	else

		# TODO what ipaddr to set ? DHCP ?

		echo "SKIP: $netdev: set IP address"

	fi

	return $ksft_skip

}
@@ -86,7 +90,7 @@ kci_netdev_ethtool_test() 
	ret=$?

	if [ $ret -ne 0 ];then

		if [ $ret -eq "$1" ];then

			echo "SKIP: $netdev: ethtool $2 not supported"

			echo "XFAIL: $netdev: ethtool $2 not supported"

			return $ksft_skip

		else

			echo "FAIL: $netdev: ethtool $2"