Unverified Commit 842bb8b6 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: ipc4-topology: Save the DMA maximum burst size for PCMs 



When setting up the pcm widget, save the DSP buffer size (in ms) for
platform code to place a constraint on playback.

On playback the DMA will fill the buffer on start and if the period
size is smaller it will immediately overrun.

On capture the DMA will move data in 1ms bursts.

Cc: stable@vger.kernel.org # 6.8
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://msgid.link/r/20240321130814.4412-3-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fb9f8125

sound/soc/sof/ipc4-topology.c

+21 −1
Original line number Diff line number Diff line
@@ -412,8 +412,9 @@ static int sof_ipc4_widget_setup_pcm(struct snd_sof_widget *swidget) 
	struct sof_ipc4_available_audio_format *available_fmt;

	struct snd_soc_component *scomp = swidget->scomp;

	struct sof_ipc4_copier *ipc4_copier;

	struct snd_sof_pcm *spcm;

	int node_type = 0;

	int ret;

	int ret, dir;



	ipc4_copier = kzalloc(sizeof(*ipc4_copier), GFP_KERNEL);

	if (!ipc4_copier)
@@ -447,6 +448,25 @@ static int sof_ipc4_widget_setup_pcm(struct snd_sof_widget *swidget) 
	}

	dev_dbg(scomp->dev, "host copier '%s' node_type %u\n", swidget->widget->name, node_type);



	spcm = snd_sof_find_spcm_comp(scomp, swidget->comp_id, &dir);

	if (!spcm)

		goto skip_gtw_cfg;



	if (dir == SNDRV_PCM_STREAM_PLAYBACK) {

		struct snd_sof_pcm_stream *sps = &spcm->stream[dir];



		sof_update_ipc_object(scomp, &sps->dsp_max_burst_size_in_ms,

				      SOF_COPIER_DEEP_BUFFER_TOKENS,

				      swidget->tuples,

				      swidget->num_tuples, sizeof(u32), 1);

		/* Set default DMA buffer size if it is not specified in topology */

		if (!sps->dsp_max_burst_size_in_ms)

			sps->dsp_max_burst_size_in_ms = SOF_IPC4_MIN_DMA_BUFFER_SIZE;

	} else {

		/* Capture data is copied from DSP to host in 1ms bursts */

		spcm->stream[dir].dsp_max_burst_size_in_ms = 1;

	}



skip_gtw_cfg:

	ipc4_copier->gtw_attr = kzalloc(sizeof(*ipc4_copier->gtw_attr), GFP_KERNEL);

	if (!ipc4_copier->gtw_attr) {