Unverified Commit 84ae7d9c authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: SOF: Disable pointless writes to debugfs file 



The permissions on this debugfs file are 0444 so it can't be written to.
And writing to the file hasn't done anything since commit 6e9548cd
("ASoC: SOF: Convert the generic IPC flood test into SOF client").
Delete the write function.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://msgid.link/r/9d2477cf-25aa-4d12-818f-fdafc9aaa28a@moroto.mountain


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 98b1bb9e

sound/soc/sof/debug.c

+0 −19
Original line number Diff line number Diff line
@@ -19,24 +19,6 @@ 
#include "sof-priv.h"

#include "ops.h"



static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer,

				  size_t count, loff_t *ppos)

{

	size_t size;

	char *string;

	int ret;



	string = kzalloc(count+1, GFP_KERNEL);

	if (!string)

		return -ENOMEM;



	size = simple_write_to_buffer(string, count, ppos, buffer, count);

	ret = size;



	kfree(string);

	return ret;

}



static ssize_t sof_dfsentry_read(struct file *file, char __user *buffer,

				 size_t count, loff_t *ppos)

{
@@ -126,7 +108,6 @@ static const struct file_operations sof_dfs_fops = { 
	.open = simple_open,

	.read = sof_dfsentry_read,

	.llseek = default_llseek,

	.write = sof_dfsentry_write,

};



/* create FS entry for debug files that can expose DSP memories, registers */