Commit 84de9180 authored by Anand Moon's avatar Anand Moon Committed by Vinod Koul
Browse files

phy: rockchip-pcie: Simplify error handling with dev_err_probe() 



Use the dev_err_probe() helper to simplify error handling during probe.
This also handle scenario, when -EDEFER is returned and useless error
is printed.

Signed-off-by: default avatarAnand Moon <linux.amoon@gmail.com>
Link: https://lore.kernel.org/r/20241012071919.3726-2-linux.amoon@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 40384c84

drivers/phy/rockchip/phy-rockchip-pcie.c

+3 −6
Original line number Diff line number Diff line
@@ -371,12 +371,9 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev) 
	mutex_init(&rk_phy->pcie_mutex);



	rk_phy->phy_rst = devm_reset_control_get(dev, "phy");

	if (IS_ERR(rk_phy->phy_rst)) {

		if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)

			dev_err(dev,

	if (IS_ERR(rk_phy->phy_rst))

		return dev_err_probe(&pdev->dev, PTR_ERR(rk_phy->phy_rst),

				     "missing phy property for reset controller\n");

		return PTR_ERR(rk_phy->phy_rst);

	}



	rk_phy->clk_pciephy_ref = devm_clk_get(dev, "refclk");

	if (IS_ERR(rk_phy->clk_pciephy_ref)) {