Commit 8515965e authored by Tuo Li's avatar Tuo Li Committed by Mauro Carvalho Chehab
Browse files

media: s5p-mfc: fix possible null-pointer dereference in s5p_mfc_probe() 



The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is
checked in:
  if (!dev->plat_dev)

This indicates both dev->plat_dev and pdev can be NULL. If so, the
function dev_err() is called to print error information.
  dev_err(&pdev->dev, "No platform data specified\n");

However, &pdev->dev is an illegal address, and it is dereferenced in
dev_err().

To fix this possible null-pointer dereference, replace dev_err() with
mfc_err().

Reported-by: default avatarTOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: default avatarTuo Li <islituo@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent ea8a5c11

drivers/media/platform/s5p-mfc/s5p_mfc.c

+1 −1
Original line number Diff line number Diff line
@@ -1283,7 +1283,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) 
	spin_lock_init(&dev->condlock);

	dev->plat_dev = pdev;

	if (!dev->plat_dev) {

		dev_err(&pdev->dev, "No platform data specified\n");

		mfc_err("No platform data specified\n");

		return -ENODEV;

	}