Commit 8532503e authored Sep 24, 2024 by Ryan Lee Committed by John Johansen Nov 26, 2024

apparmor: document capability.c:profile_capable ad ptr not being NULL

The profile_capabile function takes a struct apparmor_audit_data *ad,
which is documented as possibly being NULL. However, the single place that
calls this function never passes it a NULL ad. If we were ever to call
profile_capable with a NULL ad elsewhere, we would need to rework the
function, as its very first use of ad is to dereference ad->class without
checking if ad is NULL.

Thus, document profile_capable's ad parameter as not accepting NULL.

Signed-off-by: Ryan Lee <ryan.lee@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>

parent 9b897132

security/apparmor/capability.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -111,7 +111,7 @@ static int audit_caps(struct apparmor_audit_data ad, struct aa_profile profile
		* @profile: profile being enforced (NOT NULL, NOT unconfined)
		* @cap: capability to test if allowed
		* @opts: CAP_OPT_NOAUDIT bit determines whether audit record is generated
		* @ad: audit data (MAY BE NULL indicating no auditing)
		* @ad: audit data (NOT NULL)
		*
		* Returns: 0 if allowed else -EPERM
		*/