Commit 85520856 authored Nov 19, 2023 by Haiyang Zhang Committed by Paolo Abeni Nov 21, 2023

hv_netvsc: Fix race of register_netdevice_notifier and VF register



If VF NIC is registered earlier, NETDEV_REGISTER event is replayed,
but NETDEV_POST_INIT is not.

Move register_netdevice_notifier() earlier, so the call back
function is set before probing.

Cc: stable@vger.kernel.org
Fixes: e04e7a7b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()")
Reported-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

parent d30fb712

drivers/net/hyperv/netvsc_drv.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -2793,12 +2793,17 @@ static int __init netvsc_drv_init(void)
		}
		netvsc_ring_bytes = ring_size * PAGE_SIZE;

		register_netdevice_notifier(&netvsc_netdev_notifier);

		ret = vmbus_driver_register(&netvsc_drv);
		if (ret)
		return ret;
		goto err_vmbus_reg;

		register_netdevice_notifier(&netvsc_netdev_notifier);
		return 0;

		err_vmbus_reg:
		unregister_netdevice_notifier(&netvsc_netdev_notifier);
		return ret;
		}

		MODULE_LICENSE("GPL");