Commit 86df49e1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French
Browse files

cifsd: fix a precedence bug in parse_dacl() 



The shift has higher precedence than mask so this doesn't work as
intended.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent e3f70873

fs/cifsd/smbacl.c

+1 −1
Original line number Diff line number Diff line
@@ -520,7 +520,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl, 
			fattr->cf_gid;

		acl_state.groups->aces[acl_state.groups->n++].perms.allow =

			(mode & 0070) >> 3;

		default_acl_state.group.allow = mode & 0070 >> 3;

		default_acl_state.group.allow = (mode & 0070) >> 3;

		default_acl_state.groups->aces[default_acl_state.groups->n].gid =

			fattr->cf_gid;

		default_acl_state.groups->aces[default_acl_state.groups->n++].perms.allow =