Commit 87736ae1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

cdx: call of_node_put() on error path 



Add a missing call to of_node_put(np) on error.

There was a second error path where "np" was NULL, but that situation is
impossible.  The for_each_compatible_node() loop iterator is always
non-NULL.  Just deleted that error path.

Fixes: 54b406e1 ("cdx: Remove cdx controller list from cdx bus system")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarAbhijit Gangurde <abhijit.gangurde@amd.com>
Link: https://lore.kernel.org/r/2e66efc4-a13a-4774-8c9d-763455fe4834@moroto.mountain


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cf60af04

drivers/cdx/cdx.c

+3 −4
Original line number Diff line number Diff line
@@ -604,12 +604,11 @@ static ssize_t rescan_store(const struct bus_type *bus, 


	/* Rescan all the devices */

	for_each_compatible_node(np, NULL, compat_node_name) {

		if (!np)

			return -EINVAL;



		pd = of_find_device_by_node(np);

		if (!pd)

		if (!pd) {

			of_node_put(np);

			return -EINVAL;

		}



		cdx = platform_get_drvdata(pd);

		if (cdx && cdx->controller_registered && cdx->ops->scan)