Commit 87b42c11 authored by Dan Carpenter's avatar Dan Carpenter Committed by Dave Jiang
Browse files

cxl: fix return value in cxlctl_validate_set_features() 



The cxlctl_validate_set_features() function is type bool.  It's supposed
to return true for valid requests and false for invalid.  However, this
error path returns ERR_PTR(-EINVAL) which is true when it was intended to
return false.

The incorrect return will result in kernel failing to prevent a
incorrect op_size passed in from userspace to be detected.

[ dj: Add user impact to commit log ]

Fixes: f76e0bbc ("cxl: Update prototype of function get_support_feature_info()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/aDbFPSCujpJLY1if@stanley.mountain


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 19272b37

drivers/cxl/core/features.c

+1 −1
Original line number Diff line number Diff line
@@ -544,7 +544,7 @@ static bool cxlctl_validate_set_features(struct cxl_features_state *cxlfs, 
	u32 flags;



	if (rpc_in->op_size < sizeof(uuid_t))

		return ERR_PTR(-EINVAL);

		return false;



	feat = cxl_feature_info(cxlfs, &rpc_in->set_feat_in.uuid);

	if (IS_ERR(feat))