Commit 87be7b18 authored by Luiz Augusto von Dentz's avatar Luiz Augusto von Dentz
Browse files

Bluetooth: Fix usage of __hci_cmd_sync_status 



__hci_cmd_sync_status shall only be used if hci_req_sync_lock is _not_
required which is not the case of hci_dev_cmd so it needs to use
hci_cmd_sync_status which uses hci_req_sync_lock internally.

Fixes: f1a8f402 ("Bluetooth: L2CAP: Fix deadlock")
Reported-by: default avatarPauli Virtanen <pav@iki.fi>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 473a89b4

net/bluetooth/hci_core.c

+12 −15
Original line number Diff line number Diff line
@@ -718,7 +718,7 @@ int hci_dev_cmd(unsigned int cmd, void __user *arg) 


	switch (cmd) {

	case HCISETAUTH:

		err = __hci_cmd_sync_status(hdev, HCI_OP_WRITE_AUTH_ENABLE,

		err = hci_cmd_sync_status(hdev, HCI_OP_WRITE_AUTH_ENABLE,

					  1, &dr.dev_opt, HCI_CMD_TIMEOUT);

		break;
@@ -730,7 +730,7 @@ int hci_dev_cmd(unsigned int cmd, void __user *arg) 


		if (!test_bit(HCI_AUTH, &hdev->flags)) {

			/* Auth must be enabled first */

			err = __hci_cmd_sync_status(hdev,

			err = hci_cmd_sync_status(hdev,

						  HCI_OP_WRITE_AUTH_ENABLE,

						  1, &dr.dev_opt,

						  HCI_CMD_TIMEOUT);
@@ -738,15 +738,13 @@ int hci_dev_cmd(unsigned int cmd, void __user *arg) 
				break;

		}



		err = __hci_cmd_sync_status(hdev, HCI_OP_WRITE_ENCRYPT_MODE,

					    1, &dr.dev_opt,

					    HCI_CMD_TIMEOUT);

		err = hci_cmd_sync_status(hdev, HCI_OP_WRITE_ENCRYPT_MODE,

					  1, &dr.dev_opt, HCI_CMD_TIMEOUT);

		break;



	case HCISETSCAN:

		err = __hci_cmd_sync_status(hdev, HCI_OP_WRITE_SCAN_ENABLE,

					    1, &dr.dev_opt,

					    HCI_CMD_TIMEOUT);

		err = hci_cmd_sync_status(hdev, HCI_OP_WRITE_SCAN_ENABLE,

					  1, &dr.dev_opt, HCI_CMD_TIMEOUT);



		/* Ensure that the connectable and discoverable states

		 * get correctly modified as this was a non-mgmt change.
@@ -758,9 +756,8 @@ int hci_dev_cmd(unsigned int cmd, void __user *arg) 
	case HCISETLINKPOL:

		policy = cpu_to_le16(dr.dev_opt);



		err = __hci_cmd_sync_status(hdev, HCI_OP_WRITE_DEF_LINK_POLICY,

					    2, &policy,

					    HCI_CMD_TIMEOUT);

		err = hci_cmd_sync_status(hdev, HCI_OP_WRITE_DEF_LINK_POLICY,

					  2, &policy, HCI_CMD_TIMEOUT);

		break;



	case HCISETLINKMODE: