Commit 87bfdbbb authored by Daniel Golle's avatar Daniel Golle Committed by Jakub Kicinski
Browse files

net: phy: air_en8811h: reset netdev rules when LED is set manually 



Setting LED_OFF via brightness_set should deactivate hw control, so make
sure netdev trigger rules also get cleared in that case.
This fixes unwanted restoration of the default netdev trigger rules and
matches the behaviour when using the 'netdev' trigger without any
hardware offloading.

Fixes: 71e79430 ("net: phy: air_en8811h: Add the Airoha EN8811H PHY driver")
Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Link: https://lore.kernel.org/r/5ed8ea615890a91fa4df59a7ae8311bbdf63cdcf.1715248281.git.daniel@makrotopia.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c85e41bf

drivers/net/phy/air_en8811h.c

+4 −0
Original line number Diff line number Diff line
@@ -544,6 +544,10 @@ static int air_hw_led_on_set(struct phy_device *phydev, u8 index, bool on) 


	changed |= (priv->led[index].rules != 0);



	/* clear netdev trigger rules in case LED_OFF has been set */

	if (!on)

		priv->led[index].rules = 0;



	if (changed)

		return phy_modify_mmd(phydev, MDIO_MMD_VEND2,

				      AIR_PHY_LED_ON(index),