Commit 8805f32a authored by Hans Zhang's avatar Hans Zhang Committed by Manivannan Sadhasivam
Browse files

PCI: cadence: Fix runtime atomic count underflow 



If the call to pci_host_probe() in cdns_pcie_host_setup() fails, PM
runtime count is decremented in the error path using pm_runtime_put_sync().
But the runtime count is not incremented by this driver, but only by the
callers (cdns_plat_pcie_probe/j721e_pcie_probe). And the callers also
decrement the runtime PM count in their error path. So this leads to the
below warning from the PM core:

	"runtime PM usage count underflow!"

So fix it by getting rid of pm_runtime_put_sync() in the error path and
directly return the errno.

Fixes: 49e427e6 ("Merge branch 'pci/host-probe-refactor'")
Signed-off-by: default avatarHans Zhang <18255117159@163.com>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://patch.msgid.link/20250419133058.162048-1-18255117159@163.com
parent 0af2f6be

drivers/pci/controller/cadence/pcie-cadence-host.c

+1 −10
Original line number Diff line number Diff line
@@ -570,14 +570,5 @@ int cdns_pcie_host_setup(struct cdns_pcie_rc *rc) 
	if (!bridge->ops)

		bridge->ops = &cdns_pcie_host_ops;



	ret = pci_host_probe(bridge);

	if (ret < 0)

		goto err_init;



	return 0;



 err_init:

	pm_runtime_put_sync(dev);



	return ret;

	return pci_host_probe(bridge);

}