Commit 882826f5 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

ALSA: usb-audio: qcom: fix USB_XHCI dependency 



SND_USB_AUDIO_QMI depends on USB_XHCI_SIDEBAND, but that is a bool symbol
and allows it to be built-in even when XHCI itself is in a loadable module.
That configuration causes a link failure:

arm-linux-gnueabi-ld: sound/usb/qcom/qc_audio_offload.o: in function `uaudio_event_ring_cleanup_free':
qc_audio_offload.c:(.text+0x7dc): undefined reference to `xhci_sideband_remove_interrupter'
arm-linux-gnueabi-ld: sound/usb/qcom/qc_audio_offload.o: in function `uaudio_endpoint_setup':
qc_audio_offload.c:(.text+0xe88): undefined reference to `xhci_sideband_add_endpoint'

Add the extra dependency on USB_XHCI itself.

Fixes: 326bbc34 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250521135551.2111109-1-arnd@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e2d8ae89

sound/usb/Kconfig

+2 −1
Original line number Diff line number Diff line
@@ -178,7 +178,8 @@ config SND_BCD2000 


config SND_USB_AUDIO_QMI

	tristate "Qualcomm Audio Offload driver"

	depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && USB_XHCI_SIDEBAND && SND_SOC_USB

	depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && SND_SOC_USB

	depends on USB_XHCI_HCD && USB_XHCI_SIDEBAND

	help

	  Say Y here to enable the Qualcomm USB audio offloading feature.