Commit 883bd89d authored by Prike Liang's avatar Prike Liang Committed by Alex Deucher
Browse files

drm/amdgpu/userq: assign an error code for invalid userq va 



It should return an error code if userq VA validation fails.

Fixes: 9e46b8bb ("drm/amdgpu: validate userq buffer virtual address and size")
Signed-off-by: default avatarPrike Liang <Prike.Liang@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 90e09ea4

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

+2 −0
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ int amdgpu_userq_input_va_validate(struct amdgpu_vm *vm, u64 addr, 
		return 0;

	}



	r = -EINVAL;

out_err:

	amdgpu_bo_unreserve(vm->root.bo);

	return r;
@@ -508,6 +509,7 @@ amdgpu_userq_create(struct drm_file *filp, union drm_amdgpu_userq *args) 
	if (amdgpu_userq_input_va_validate(&fpriv->vm, args->in.queue_va, args->in.queue_size) ||

	    amdgpu_userq_input_va_validate(&fpriv->vm, args->in.rptr_va, AMDGPU_GPU_PAGE_SIZE) ||

	    amdgpu_userq_input_va_validate(&fpriv->vm, args->in.wptr_va, AMDGPU_GPU_PAGE_SIZE)) {

		r = -EINVAL;

		kfree(queue);

		goto unlock;

	}