Commit 8894b928 authored by Roman Li's avatar Roman Li Committed by Alex Deucher
Browse files

drm/amd/display: Disable ips before dc interrupt setting 



[Why]
While in IPS2 an access to dcn registers is not allowed.
If interrupt results in dc call, we should disable IPS.

[How]
Safeguard register access in IPS2 by disabling idle optimization
before calling dc interrupt setting api.

Signed-off-by: default avatarRoman Li <Roman.Li@amd.com>
Tested-by: default avatarMark Broadworth <mark.broadworth@amd.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f37f7979

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c

+4 −1
Original line number Diff line number Diff line
@@ -711,7 +711,7 @@ static inline int dm_irq_state(struct amdgpu_device *adev, 
{

	bool st;

	enum dc_irq_source irq_source;



	struct dc *dc = adev->dm.dc;

	struct amdgpu_crtc *acrtc = adev->mode_info.crtcs[crtc_id];



	if (!acrtc) {
@@ -729,6 +729,9 @@ static inline int dm_irq_state(struct amdgpu_device *adev, 


	st = (state == AMDGPU_IRQ_STATE_ENABLE);



	if (dc && dc->caps.ips_support && dc->idle_optimizations_allowed)

		dc_allow_idle_optimizations(dc, false);



	dc_interrupt_set(adev->dm.dc, irq_source, st);

	return 0;

}