Unverified Commit 89fe4601 authored by Maíra Canal's avatar Maíra Canal
Browse files

drm/v3d: Fix support for register debugging on the RPi 4 



RPi 4 uses V3D 4.2, which is currently not supported by the register
definition stated at `v3d_core_reg_defs`. We should be able to support
V3D 4.2, therefore, change the maximum version of the register
definition to 42, not 41.

Fixes: 0ad5bc1c ("drm/v3d: fix up register addresses for V3D 7.x")
Signed-off-by: default avatarMaíra Canal <mcanal@igalia.com>
Reviewed-by: default avatarIago Toral Quiroga <itoral@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240109113126.929446-1-mcanal@igalia.com
parent 196da3f3

drivers/gpu/drm/v3d/v3d_debugfs.c

+10 −10
Original line number Diff line number Diff line
@@ -62,9 +62,9 @@ static const struct v3d_reg_def v3d_core_reg_defs[] = { 
	REGDEF(33, 71, V3D_PTB_BPCA),

	REGDEF(33, 71, V3D_PTB_BPCS),



	REGDEF(33, 41, V3D_GMP_STATUS(33)),

	REGDEF(33, 41, V3D_GMP_CFG(33)),

	REGDEF(33, 41, V3D_GMP_VIO_ADDR(33)),

	REGDEF(33, 42, V3D_GMP_STATUS(33)),

	REGDEF(33, 42, V3D_GMP_CFG(33)),

	REGDEF(33, 42, V3D_GMP_VIO_ADDR(33)),



	REGDEF(33, 71, V3D_ERR_FDBGO),

	REGDEF(33, 71, V3D_ERR_FDBGB),
@@ -74,13 +74,13 @@ static const struct v3d_reg_def v3d_core_reg_defs[] = { 


static const struct v3d_reg_def v3d_csd_reg_defs[] = {

	REGDEF(41, 71, V3D_CSD_STATUS),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG0(41)),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG1(41)),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG2(41)),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG3(41)),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG4(41)),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG5(41)),

	REGDEF(41, 41, V3D_CSD_CURRENT_CFG6(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG0(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG1(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG2(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG3(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG4(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG5(41)),

	REGDEF(41, 42, V3D_CSD_CURRENT_CFG6(41)),

	REGDEF(71, 71, V3D_CSD_CURRENT_CFG0(71)),

	REGDEF(71, 71, V3D_CSD_CURRENT_CFG1(71)),

	REGDEF(71, 71, V3D_CSD_CURRENT_CFG2(71)),