Unverified Commit 8a0ec8c2 authored by Yang Ruibin's avatar Yang Ruibin Committed by Mark Brown
Browse files

spi: Insert the missing pci_dev_put()before return 



Increase the reference count by calling pci_get_slot(), and remember to
decrement the reference count by calling pci_dev_put().

Signed-off-by: default avatarYang Ruibin <11162571@vivo.com>
Link: https://patch.msgid.link/20240829033511.1917015-1-11162571@vivo.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2fe6102b

drivers/spi/spi-pxa2xx-pci.c

+6 −2
Original line number Diff line number Diff line
@@ -145,8 +145,10 @@ static int lpss_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) 
	c->num_chipselect = 1;



	ret = pxa2xx_spi_pci_clk_register(dev, ssp, 50000000);

	if (ret)

	if (ret) {

		pci_dev_put(dma_dev);

		return ret;

	}



	dma_dev = pci_get_slot(dev->bus, PCI_DEVFN(PCI_SLOT(dev->devfn), 0));

	ret = devm_add_action_or_reset(&dev->dev, lpss_dma_put_device, dma_dev);
@@ -221,8 +223,10 @@ static int mrfld_spi_setup(struct pci_dev *dev, struct pxa2xx_spi_controller *c) 
	}



	ret = pxa2xx_spi_pci_clk_register(dev, ssp, 25000000);

	if (ret)

	if (ret) {

		pci_dev_put(dma_dev);

		return ret;

	}



	dma_dev = pci_get_slot(dev->bus, PCI_DEVFN(21, 0));

	ret = devm_add_action_or_reset(&dev->dev, lpss_dma_put_device, dma_dev);