Unverified Commit 8b6e28ea authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Maxime Ripard
Browse files

drm/modes: parse_cmdline: Add support for named modes containing dashes 



It is fairly common for named video modes to contain dashes (e.g.
"tt-mid" on Atari, "dblntsc-ff" on Amiga).  Currently such mode names
are not recognized, as the dash is considered to be a separator between
mode name and bpp.

Fix this by skipping any dashes that are not followed immediately by a
digit when looking for the separator.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220728-rpi-analog-tv-properties-v4-13-60d38873f782@cerno.tech


Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
parent 90c258ba

drivers/gpu/drm/drm_modes.c

+2 −0
Original line number Diff line number Diff line
@@ -1810,6 +1810,8 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, 


	/* Try to locate the bpp and refresh specifiers, if any */

	bpp_ptr = strnchr(name, options_off, '-');

	while (bpp_ptr && !isdigit(bpp_ptr[1]))

		bpp_ptr = strnchr(bpp_ptr + 1, options_off, '-');

	if (bpp_ptr)

		bpp_off = bpp_ptr - name;