Commit 8b75c297 authored Mar 05, 2025 by Neil Armstrong Committed by Bjorn Andersson Mar 05, 2025

clk: qcom: gcc-sm8650: Do not turn off USB GDSCs during gdsc_disable()

With PWRSTS_OFF_ON, USB GDSCs are turned off during gdsc_disable(). This
can happen during scenarios such as system suspend and breaks the resume
of USB controller from suspend.

So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs
during gdsc_disable() and allow the hardware to transition the GDSCs to
retention when the parent domain enters low power state during system
suspend.

Fixes: c58225b7 ("clk: qcom: add the SM8650 Global Clock Controller driver, part 1")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250305-topic-sm8650-upstream-fix-usb-suspend-v1-1-649036ab0557@linaro.org

Signed-off-by: Bjorn Andersson <andersson@kernel.org>

parent a8e4ab5b

drivers/clk/qcom/gcc-sm8650.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3497,7 +3497,7 @@ static struct gdsc usb30_prim_gdsc = {
		.pd = {
		.name = "usb30_prim_gdsc",
		},
		.pwrsts = PWRSTS_OFF_ON,
		.pwrsts = PWRSTS_RET_ON,
		.flags = POLL_CFG_GDSCR \| RETAIN_FF_ENABLE,
		};

		@@ -3506,7 +3506,7 @@ static struct gdsc usb3_phy_gdsc = {
		.pd = {
		.name = "usb3_phy_gdsc",
		},
		.pwrsts = PWRSTS_OFF_ON,
		.pwrsts = PWRSTS_RET_ON,
		.flags = POLL_CFG_GDSCR \| RETAIN_FF_ENABLE,
		};