Commit 8bc7ba3d authored by Israel Batista's avatar Israel Batista Committed by Andrew Morton
Browse files

mm: change type of state in struct memory_block 

The state of a memory block should be restricted to values specified in
the documentation of the memory hotplug API.  However, since the state
field in the memory_block struct was defined as an unsigned long, this
restriction was not enforced at compile time.

With the introduction of the enum memory_block_state, it is now possible
to incorporate the desired semantics in the field declaration and enforce
these restrictions at compile time.

[akpm@linux-foundation.org: fix whitespace, per Randy]
Link: https://lkml.kernel.org/r/20251029195617.2210700-3-linux@israelbatista.dev.br


Signed-off-by: default avatarIsrael Batista <linux@israelbatista.dev.br>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Acked-by: default avatarMike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: default avatarLorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Omar Sandoval <osandov@osandov.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1a4f70f6

drivers/base/memory.c

+1 −1
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, 
		break;

	default:

		WARN_ON(1);

		return sysfs_emit(buf, "ERROR-UNKNOWN-%ld\n", mem->state);

		return sysfs_emit(buf, "ERROR-UNKNOWN-%d\n", mem->state);

	}



	return sysfs_emit(buf, "%s\n", output);

include/linux/memory.h

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ enum memory_block_state { 


struct memory_block {

	unsigned long start_section_nr;

	unsigned long state;		/* serialized by the dev->lock */

	enum memory_block_state state;	/* serialized by the dev->lock */

	int online_type;		/* for passing data to online routine */

	int nid;			/* NID for this memory block */

	/*