Commit 8c3fdff2 authored by Breno Leitao's avatar Breno Leitao Committed by Paolo Abeni
Browse files

openvswitch: Move stats allocation to core 



With commit 34d21de9 ("net: Move {l,t,d}stats allocation to core and
convert veth & vrf"), stats allocation could be done on net core instead
of this driver.

With this new approach, the driver doesn't have to bother with error
handling (allocation failure checking, making sure free happens in the
right spot, etc). This is core responsibility now.

Move openvswitch driver to leverage the core allocation.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20240531111552.3209198-1-leitao@debian.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent cd0057ad

net/openvswitch/vport-internal_dev.c

+1 −8
Original line number Diff line number Diff line
@@ -140,11 +140,7 @@ static struct vport *internal_dev_create(const struct vport_parms *parms) 
		err = -ENOMEM;

		goto error_free_vport;

	}

	vport->dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);

	if (!vport->dev->tstats) {

		err = -ENOMEM;

		goto error_free_netdev;

	}

	dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS;



	dev_net_set(vport->dev, ovs_dp_get_net(vport->dp));

	dev->ifindex = parms->desired_ifindex;
@@ -169,8 +165,6 @@ static struct vport *internal_dev_create(const struct vport_parms *parms) 


error_unlock:

	rtnl_unlock();

	free_percpu(dev->tstats);

error_free_netdev:

	free_netdev(dev);

error_free_vport:

	ovs_vport_free(vport);
@@ -186,7 +180,6 @@ static void internal_dev_destroy(struct vport *vport) 


	/* unregister_netdevice() waits for an RCU grace period. */

	unregister_netdevice(vport->dev);

	free_percpu(vport->dev->tstats);

	rtnl_unlock();

}