Commit 8d3739db authored by Andrew Davis's avatar Andrew Davis Committed by Mathieu Poirier
Browse files

remoteproc: omap: Use devm_rproc_add() helper 



Use the device lifecycle managed add function. This helps prevent mistakes
like deleting out of order in cleanup functions and forgetting to delete
on error paths.

Signed-off-by: default avatarAndrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240610151721.189472-3-afd@ti.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 5efcc364

drivers/remoteproc/omap_remoteproc.c

+1 −9
Original line number Diff line number Diff line
@@ -1359,20 +1359,13 @@ static int omap_rproc_probe(struct platform_device *pdev) 


	platform_set_drvdata(pdev, rproc);



	ret = rproc_add(rproc);

	ret = devm_rproc_add(&pdev->dev, rproc);

	if (ret)

		return ret;



	return 0;

}



static void omap_rproc_remove(struct platform_device *pdev)

{

	struct rproc *rproc = platform_get_drvdata(pdev);



	rproc_del(rproc);

}



static const struct dev_pm_ops omap_rproc_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(omap_rproc_suspend, omap_rproc_resume)

	SET_RUNTIME_PM_OPS(omap_rproc_runtime_suspend,
@@ -1381,7 +1374,6 @@ static const struct dev_pm_ops omap_rproc_pm_ops = { 


static struct platform_driver omap_rproc_driver = {

	.probe = omap_rproc_probe,

	.remove_new = omap_rproc_remove,

	.driver = {

		.name = "omap-rproc",

		.pm = &omap_rproc_pm_ops,