Commit 8d55027f authored by Dan Carpenter's avatar Dan Carpenter Committed by Vinod Koul
Browse files

phy: ti: gmii-sel: check of_get_address() for failure 



Smatch complains that if of_get_address() returns NULL, then "size"
isn't initialized.  Also it would lead to an Oops.

Fixes: 7f78322c ("phy: ti: gmii-sel: retrieve ports number and base offset from dt")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
Link: https://lore.kernel.org/r/20210914110038.GB11657@kili


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent d8b951ab

drivers/phy/ti/phy-gmii-sel.c

+2 −0
Original line number Diff line number Diff line
@@ -320,6 +320,8 @@ static int phy_gmii_sel_init_ports(struct phy_gmii_sel_priv *priv) 
		u64 size;



		offset = of_get_address(dev->of_node, 0, &size, NULL);

		if (!offset)

			return -EINVAL;

		priv->num_ports = size / sizeof(u32);

		if (!priv->num_ports)

			return -EINVAL;