Unverified Commit 8dab34ca authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

platform/x86: think-lmi: Create ksets consecutively 



Avoid entering tlmi_release_attr() in error paths if both ksets are not
yet created.

This is accomplished by initializing them side by side.

Reviewed-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250630-lmi-fix-v3-1-ce4f81c9c481@gmail.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 644bec18

drivers/platform/x86/think-lmi.c

+8 −6
Original line number Diff line number Diff line
@@ -1455,6 +1455,14 @@ static int tlmi_sysfs_init(void) 
		goto fail_device_created;

	}



	tlmi_priv.authentication_kset = kset_create_and_add("authentication", NULL,

							    &tlmi_priv.class_dev->kobj);

	if (!tlmi_priv.authentication_kset) {

		kset_unregister(tlmi_priv.attribute_kset);

		ret = -ENOMEM;

		goto fail_device_created;

	}



	for (i = 0; i < TLMI_SETTINGS_COUNT; i++) {

		/* Check if index is a valid setting - skip if it isn't */

		if (!tlmi_priv.setting[i])
@@ -1496,12 +1504,6 @@ static int tlmi_sysfs_init(void) 
	}



	/* Create authentication entries */

	tlmi_priv.authentication_kset = kset_create_and_add("authentication", NULL,

								&tlmi_priv.class_dev->kobj);

	if (!tlmi_priv.authentication_kset) {

		ret = -ENOMEM;

		goto fail_create_attr;

	}

	tlmi_priv.pwd_admin->kobj.kset = tlmi_priv.authentication_kset;

	ret = kobject_add(&tlmi_priv.pwd_admin->kobj, NULL, "%s", "Admin");

	if (ret)